[CMake] Don't set LD_LIBRARY_PATH in test macros #20407
Conversation
guitargeek
force-pushed
the
ld_library_path
branch
from
577e953 to
c5eaaa2
Compare
Test Results 22 files 22 suites 3d 20h 44m 51s ⏱️ For more details on these failures, see this check. Results for commit ca5317f. ♻️ This comment has been updated with latest results. |
|
The failures are understandable, because the "main" libraries and executables don't contain runpaths to find libraries that are part of tests. For these, it's probably OK to continue setting LD_LIBRARY_PATH, but |
Ok makes sense! I'll see what can be done about that. |
guitargeek
force-pushed
the
ld_library_path
branch
5 times, most recently
from
b9310b6 to
3b9f2b6
Compare
So far, we have only solved this problem by adding the path to `DYLD_LIBRARY_PATH` when running the test, but this is not a complete solution, as the libraries won't be found automatically if this is not set. That affects in particular the users that want to use `h2root` from the install tree. Using the RPATH mechanism is more appropriate here.
This should not be needed anymore because of the runpath mechanism, and by leaving it out from the test environment we are making sure that this keeps working.
guitargeek
force-pushed
the
ld_library_path
branch
from
3b9f2b6 to
ca5317f
Compare
|
Test failure is unrelated. It's because I had to remove chromium from the rawhide image, and there was no clean CMake re-configuration yet that recognized that there is no chrome browser available. |
2 participants
This should not be needed anymore because of the runpath mechanism, and by leaving it out from the test environment we are making sure that this keeps working.